Comments

diff --git a/perl/sct6 b/perl/sct6
index fde8f7f75d5604370c5dfb199f692ef845b48b7f..abfede15d0187e7552f5c51600b257b721113678 100755 (executable)
--- a/perl/sct6
+++ b/perl/sct6
@@ -9,7 +9,6 @@
 use strict;
 use LWP::UserAgent;
 use HTML::TableExtract;
-#use Time::Local;
 use Date::Calc::Object qw(Day_of_Week Decode_Day_of_Week Decode_Month Week_of_Year Monday_of_Week Day_of_Week_Abbreviation Delta_Days Add_Delta_Days Nth_Weekday_of_Month_Year Gmtime Mktime);
 use Date::Calendar::Profiles qw($Profiles);
 use Date::Calendar::Year;
@@ -91,7 +90,7 @@ $response = $ua->post("${url}twbkwbis.P_ValLogin", { sid => $opts{SID}, PIN => $
 
 $response = $ua->get("${url}bwskflib.P_SelDefTerm"); # Valid terms
 die $response->status_line unless $response->is_success;
-my @terms = grep {s/^<option value="([^"]*)">.*/$1/i} (split( /\r?\n/, $response->content));
+my @terms = grep {s/^<option value="([^"]*)">.*/$1/i} (split( /\r?\n/, $response->content)); # "
 die "Site down. Try again later.\n" unless (@terms);
 
 sub generate_id {
@@ -208,7 +207,8 @@ sub capitalize {
 
 sub get_schedule_terms {
     my (@sterms, @a);
-    @a=('10','20','30','40'); # XXX 10 is fall, others are speculation
+    @a=('10','20','30','40');  # Fall, Spring, Summer I, Summer II
+                               # Last 3 are currently guesses
     my @localtime=localtime();
     if ($localtime[4]<3) { # Through Mar 31
        @sterms=((1900+$localtime[5]).$a[1]);
@@ -230,8 +230,6 @@ sub get_schedule {
     my @readheaders = ("Type", "Time", "Days", "Where", "Date Range", "Schedule Type", "Instructors");
     my @class;
     my $te = new HTML::TableExtract( headers => [ @readheaders ] );
-    #@readheaders = ("Course", "Days\xa0TimeLocation", "Session and Dates", "Instructor", "Credit", "CallNumber", "GradeType", "Message");
-    my $tf = new HTML::TableExtract( headers => [ @readheaders ] );
     my (@schedule, @terms, $classid, $title, $begin, $end, $times, $days, $session);
     @terms = get_schedule_terms();
     foreach (@_ ? @_ : @terms) {
@@ -242,8 +240,6 @@ sub get_schedule {
            next unless $l =~ s/.*<CAPTION class=[^>]*>(.* - .... \d\d\d\d \d\d\d)<\/caption>.*/$1/i;
            push @class, $l;
        }
-       #$tf->parse($response->content);
-       #print $response->content;
     }
     foreach my $ts ($te->table_states) {
        foreach my $row ($ts->rows) {
@@ -292,7 +288,6 @@ sub get_schedule {
                location => $row->[3],
                #message => $row->[10],
            };
-           #print join (" ", values %{$schedule[$#schedule]}), "\n";
        }
     }
     return @schedule;
@@ -574,24 +569,6 @@ sub do_html_grades {
     print "</table>\n";
 }
 
-sub do_faculty {
-    my @readheaders = ("Name", "College", "Email");
-    my $te = new HTML::TableExtract( headers => [ @readheaders ] );
-    foreach(qw(a b c d e f g h i j k l m n o p q r s t u v w x y z)) {
-       my $response = $ua->get("http://$domain/fs/".$_."dir.htm");
-       die $response->status_line unless $response->is_success;
-       $te->parse($response->content);
-    }
-    foreach my $ts ($te->table_states) {
-       foreach my $row ($ts->rows) {
-           map { s/[\r\n]//g; $_} @$row;
-           $row->[0] = capitalize($row->[0]);
-           $row->[0] =~ s/([A-Z]r?)$/$1./;
-           print '"'.$row->[0].'",',$row->[2].',', $row->[1], "\n";
-       }
-    }
-}
-
 sub do_transcripts {
     $response = $ua->get("$url&tserve_tip_write=||WID|SID|PIN&tserve_trans_config=rtranscr.cfg&CareerReqNum=1");
     foreach (split /\n/, $response->content) {
@@ -603,6 +580,7 @@ sub do_transcripts {
 }
 
 if ($arg eq "-g") {
+    die "Grade support currently broken.\n";
     do_html_grades(@ARGV);
 } elsif ($arg eq "-s") {
     do_html_schedule(@ARGV);
@@ -613,9 +591,8 @@ if ($arg eq "-g") {
 } elsif ($arg eq "-v") {
     do_vcalendar_schedule(@ARGV);
 } elsif ($arg eq "-t") {
+    die "Transcript support currently broken.\n";
     do_transcripts;
-} elsif ($arg eq "-f") {
-    do_faculty;
 }
 
 $ua->get("${url}twbkwbis.P_Logout"); # Logout

diff --git a/perl/sctweb b/perl/sctweb
index f78ca86858e0cd24680255d756726b5c3bf7c112..c1d82d6d8220e0bf1fe3b7c0da92a82ad35d9299 100755 (executable)
--- a/perl/sctweb
+++ b/perl/sctweb
@@ -91,7 +91,7 @@ $response = $ua->post("$url&tserve_trans_config=astulog.cfg", { tserve_tip_write
 
 $response = $ua->get("$url&tserve_tip_write=||WID|SID|PIN|Term&tserve_trans_config=" . ("regterm.cfg"||"rgrdterm.cfg")); # Valid terms
 die $response->status_line unless $response->is_success;
-my @terms = grep {s/^<option value="([^"]*)">.*/$1/} (split( /\r\n/, $response->content));
+my @terms = grep {s/^<option value="([^"]*)">.*/$1/} (split( /\r\n/, $response->content)); # "
 if(@terms) {
     $opts{school} = 'accd';
 } else {